-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidepool Merge #2237
Open
ps2
wants to merge
242
commits into
dev
Choose a base branch
from
tidepool-merge
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tidepool Merge #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LOOP-4735 CGM Event Store
* Changes for functional algorithm recommendations * Remove limits from IRC * Simplify prediction input to only need those elements necessary for prediction * LoopAlgorithm recommendations compiling * LoopAlgorithm.generatePrediction parameters are extracted from LoopPredictionInput struct * Comparable implementation for ManualBolusRecommendation has moved to LoopKit
…o status highlight (#607)
* Start work on new LoopDataManager using stateless algorithm * Fetching data for new ldm * LoopDosingManager * Fix method parameter names * LoopDosingManager handling automatic dosing * Consolidating presets management into TemporaryPresetsManager * Presets consolidation * Reorg back to LoopDataManager * Main status table view updates * Bolus view fetching algo input * Fix iob graph issue * Get active carb values for graph time frame * Notify on update of settings * Fix carb display and edit * Update active insulin and active carbs in bolus entry view * Restore active preset, and add note about premeal. Always confirm override deactivation. * Refactoring * Mocking for simplifying DeviceDataManagerTests * Fixing more tests * LoopDataManager tests all passing * Fixing tests * Meal detection manager tests * Update remote recommendations * TemporaryPresetsManagerTests * BolusEntryView use recommendManualBolus * Add tests for max iob * Cleanup * Cleanup * LoopSettingsTests were just overrides tests, and have been moved to TemporaryPresetsManagerTests * Get active insulin from loop display state * Update from PR feedback * Assert DeviceDataManager triggers alert upload * Remove unused method * Guard against missing glucose
Temporarily Disable Favorite Foods
…teChanged (#614) * refactoring CancelTempBasalFailedError when .maximumBasalRateChanged * clean up * response to PR comment
* Overlay basal from history timeline instead of schedule * Remove file
Conflicts: Loop Status Extension/it.lproj/Localizable.strings Loop Widget Extension/Helpers/ContentMargin.swift Loop Widget Extension/Helpers/WidgetBackground.swift Loop.xcodeproj/project.pbxproj Loop/AppDelegate.swift Loop/Managers/Alerts/StoredAlert.swift Loop/Managers/AppExpirationAlerter.swift Loop/Managers/LoopDataManager.swift Loop/Managers/RemoteDataServicesManager.swift Loop/View Models/CarbEntryViewModel.swift LoopTests/Managers/Alerts/AlertStoreTests.swift LoopTests/Managers/Alerts/StoredAlertTests.swift
…cking (#712) * Update Loop for LoopKit api changes for avoiding thread blocking * Fix non-deterministic test behavior * Updates to use latest LoopAlgorithm package
…F timeline (#716) * Fix a couple of bugs in determining span of time to use for ISF timeline * Use isf interval helper, and fix bugs with bolus preview and forecast details
* OnboardingManager is a PluginHost * Update Common/Extensions/NSBundle.swift Co-authored-by: Cameron Ingham <camji555@gmail.com> --------- Co-authored-by: Cameron Ingham <camji555@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.