🔧 Display 404 page #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔧 Ensure "/looptips/" path prefix is present locally and on GitHub Pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures
/looptips/path prefix is present locally and on GitHub Pages URLs.It fixes an issue where the 404 page was broken due to invalid links.
Even if the
/looptips/path prefix is always present in LoopTips' static URLs it is not in dynamic URLs.Some URLs are built dynamically like the ones in
404.htmlwhich makes this page broken because its assets (CSS, images...) are searched in/instead of their actual location/looptips/.This PR fixes this by making things explicit by adding this prefix to the path using the
site_urlproperty:Below is a screenshot of the broken
404.htmlwhen rendered.