Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike group v1 label compatability #1238

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Spike group v1 label compatability #1238

merged 4 commits into from
Feb 20, 2025

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Feb 19, 2025 •
edited
Loading

Description

Checklist:

  • N This PR should be accompanied by a release: (yes/no/unsure)
  • NA If release, I have updated the CITATION.cff
  • N This PR makes edits to table definitions: (yes/no)
  • NA If table edits, I have included an alter snippet for release notes.
  • NA If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • NA I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 marked this pull request as ready for review February 19, 2025 19:21
CBroz1
CBroz1 approved these changes Feb 19, 2025
View reviewed changes
@samuelbray32 @CBroz1
Update src/spyglass/spikesorting/analysis/v1/group.py
684e141 
Co-authored-by: Chris Broz <Chris.Broz@ucsf.edu>
@edeno edeno merged commit 5d92219 into master Feb 20, 2025
17 checks passed
@edeno edeno deleted the 1236_fix branch February 20, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBroz1 CBroz1 CBroz1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

problem filtering units with SortedSpikeGroup
3 participants
@samuelbray32 @CBroz1 @edeno