Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key length solve: Reduce varchars #664

Merged
merged 20 commits into from
Nov 8, 2023
Merged

Key length solve: Reduce varchars #664

merged 20 commits into from
Nov 8, 2023

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented Oct 20, 2023

Description

This reduces varchar lengths to address #630, with the goal of being able to declare all tables without error on a vanilla MySQL 8 instance. Work elsewhere will help with database surgery later, for help our database conform to the changes here.

Checklist:

  • This PR should be accompanied by a release: (yes/no/unsure)
  • (If release) I have updated the CITATION.cff
  • I have updated the CHANGELOG.md
  • I have added/edited docs/notebooks to reflect the changes - n/a

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CBroz1 CBroz1 marked this pull request as ready for review November 8, 2023 00:15
@edeno edeno merged commit 3ce16f6 into LorenFrankLab:master Nov 8, 2023
7 checks passed
@CBroz1 CBroz1 mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants