Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Escape button via deleting useless macOS specific WindowTitleBarBox #119

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

XMLHexagram
Copy link
Collaborator

@XMLHexagram XMLHexagram commented Nov 25, 2024

close #118

After reading the code and during experiments, I believe the deleted macOS specific WindowTitleBarBox is legacy and is the cause of #118. Therefore, I removed it to solve that issue.

Summary by Sourcery

Bug Fixes:

  • Remove the macOS specific WindowTitleBarBox to fix the issue causing the Escape button malfunction.

Copy link

sourcery-ai bot commented Nov 25, 2024

Reviewer's Guide by Sourcery

This PR removes a macOS-specific WindowTitleBarBox widget that was causing issues with the escape button functionality (issue #118). The implementation simply deletes the unnecessary code block that was wrapping a Container widget with a fixed width of 28 pixels.

Class diagram for NavigationBarState changes

classDiagram
    class NavigationBarState {
        - WindowTitleBarBox (macOS specific)
    }
    note for NavigationBarState "Removed macOS specific WindowTitleBarBox widget"
Loading

File-Level Changes

Change Details Files
Remove legacy macOS-specific window title bar box
  • Delete conditional rendering of WindowTitleBarBox widget
  • Remove container with fixed width of 28 pixels
lib/widgets/navigation_bar/navigation_bar.dart

Assessment against linked issues

Issue Objective Addressed Explanation
#118 Fix the incorrectly positioned escape/close button in the search interface on macOS

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@XMLHexagram XMLHexagram requested a review from Losses November 25, 2024 21:29
@XMLHexagram XMLHexagram self-assigned this Nov 25, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @XMLHexagram - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Losses Losses merged commit 5b4bd97 into Losses:master Nov 25, 2024
@XMLHexagram XMLHexagram deleted the fix_118 branch November 27, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS: Escape from search button misses in search
2 participants