Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macOS): Ablum title offset #166

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

XMLHexagram
Copy link
Collaborator

@XMLHexagram XMLHexagram commented Dec 3, 2024

CleanShot 2024-12-03 at 21 49 49@2x

The parent title and child title both have a left offset of 24px, but due to font and typography reasons, they are not perfectly aligned visually.

IDK how to fix it, @Losses Could you provide some help?

Summary by Sourcery

Bug Fixes:

  • Fix the alignment of album titles on macOS by adjusting the left padding to 24px.

Copy link

sourcery-ai bot commented Dec 3, 2024

Reviewer's Guide by Sourcery

This PR fixes a visual alignment issue on macOS where album titles appear misaligned due to font and typography differences. The implementation adjusts the left padding specifically for macOS and adds proper alignment for the text scaling transformation.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Implement platform-specific padding for title alignment
  • Added platform check to conditionally apply different left padding on macOS (24px) vs other platforms (20px)
  • Added left alignment to the scale transformation to maintain proper text positioning
lib/screens/query_tracks/query_tracks.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @XMLHexagram - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider implementing a more systematic approach for handling platform-specific typography alignment rather than using hardcoded padding values. This could help prevent similar issues in other parts of the UI.
  • There's a typo in the PR title: 'Ablum' should be 'Album'
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Losses Losses merged commit 6b4d96b into master Dec 3, 2024
2 of 4 checks passed
@Losses Losses deleted the fix-macos-ablum-title-offset branch December 4, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants