Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update shortcut alt+N -> option+N on macOS #87

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

XMLHexagram
Copy link
Collaborator

@XMLHexagram XMLHexagram commented Nov 19, 2024

Summary by Sourcery

Bug Fixes:

  • Correct the keyboard shortcut display from 'Alt+N' to '⌥+N' for macOS users.

Copy link

sourcery-ai bot commented Nov 19, 2024

Reviewer's Guide by Sourcery

The PR updates the keyboard shortcut display text for the cover wall feature to show the correct modifier key symbol (⌥) on macOS while keeping 'Alt' for other platforms. This is implemented by adding a platform check and using conditional text rendering.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added platform-specific shortcut text display for the cover wall feature
  • Imported the Platform class from dart:io
  • Updated ShortcutText widget to conditionally display '⌥+N' on macOS and 'Alt+N' on other platforms
lib/widgets/playback_controller/constants/controller_items.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @XMLHexagram - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Losses Losses merged commit 4d820b9 into Losses:master Nov 20, 2024
@XMLHexagram XMLHexagram deleted the shortcur-use-macos-key branch November 27, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants