Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update format for intl_ja #88

Merged
merged 31 commits into from
Nov 20, 2024
Merged

Update format for intl_ja #88

merged 31 commits into from
Nov 20, 2024

Conversation

NovaDNG
Copy link
Contributor

@NovaDNG NovaDNG commented Nov 20, 2024

Also add translation for log section

Summary by Sourcery

Documentation:

  • Add translation for the log section in the Japanese localization file.

Slight visual polish
Inspired by KM5 CP1
KATAKANA MUST DIE
merge format from intl_en
Copy link

sourcery-ai bot commented Nov 20, 2024

Reviewer's Guide by Sourcery

This pull request updates the Japanese internationalization file by adding translations for the log section. The changes are straightforward text additions and modifications to the existing translation file.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added new Japanese translations for the log section
  • Added new translation entries
  • Updated existing translation content
lib/l10n/intl_ja.arb

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @NovaDNG - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide a more detailed description of the changes being made, including the purpose of the format updates and which log section translations were added. This context helps reviewers and future maintainers understand the modifications.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Losses Losses merged commit 6ca4303 into Losses:master Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants