Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: macos dev install script #95

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

laosb
Copy link
Contributor

@laosb laosb commented Nov 21, 2024

  • fix rustup install command
  • remove brew install rust
  • install stable rust using rustup

Summary by Sourcery

Fix the macOS development installation script by correcting the rustup installation command, removing the Homebrew Rust installation, and setting the default Rust version to stable using rustup.

Bug Fixes:

  • Correct the rustup installation command in the macOS development script.

Enhancements:

  • Remove the installation of Rust via Homebrew in favor of using rustup.

- fix rustup install command
- remove brew install rust
- install stable rust using rustup
Copy link

sourcery-ai bot commented Nov 21, 2024

Reviewer's Guide by Sourcery

This PR fixes the macOS development environment setup script by correcting the Rust installation process. Instead of installing Rust through Homebrew, it now uses rustup to manage the Rust toolchain, ensuring a more standardized installation method.

Sequence diagram for macOS dev install script changes

sequenceDiagram
    participant User
    participant Script
    participant Homebrew
    participant Rustup

    User->>Script: Run macos_1_install.sh
    Script->>Homebrew: Install Flutter
    Script->>Rustup: Install rustup
    Script->>Rustup: Set default Rust to stable
    Script->>Rustup: Add target x86_64-apple-darwin
    Script->>Rustup: Add target aarch64-apple-darwin
Loading

File-Level Changes

Change Details Files
Modify Rust installation and configuration process
  • Remove Homebrew-based Rust installation
  • Install rustup package manager only
  • Set default Rust toolchain to stable version
  • Keep existing cross-compilation target configurations
scripts/macos_1_install.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @laosb - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Collaborator

@XMLHexagram XMLHexagram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XMLHexagram XMLHexagram merged commit 7409abc into Losses:master Nov 21, 2024
@laosb laosb deleted the fix-macos-install branch November 21, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants