-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: macos dev install script #95
Conversation
- fix rustup install command - remove brew install rust - install stable rust using rustup
Reviewer's Guide by SourceryThis PR fixes the macOS development environment setup script by correcting the Rust installation process. Instead of installing Rust through Homebrew, it now uses rustup to manage the Rust toolchain, ensuring a more standardized installation method. Sequence diagram for macOS dev install script changessequenceDiagram
participant User
participant Script
participant Homebrew
participant Rustup
User->>Script: Run macos_1_install.sh
Script->>Homebrew: Install Flutter
Script->>Rustup: Install rustup
Script->>Rustup: Set default Rust to stable
Script->>Rustup: Add target x86_64-apple-darwin
Script->>Rustup: Add target aarch64-apple-darwin
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @laosb - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary by Sourcery
Fix the macOS development installation script by correcting the rustup installation command, removing the Homebrew Rust installation, and setting the default Rust version to stable using rustup.
Bug Fixes:
Enhancements: