Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run bun install when mix setup is run #2

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

axelson
Copy link
Contributor

@axelson axelson commented Nov 18, 2024

Without this on a fresh repo when you run mix setup you get errors like:

26 | import "@appnest/masonry-layout";
            ^
error: Could not resolve: "@appnest/masonry-layout". Maybe you need to "bun install"?
    at /Users/jason/dev/forks/kobrakai_elixir/assets/js/app.js:26:8
** (Mix) `mix bun default` exited with 1

@LostKobrakai
Copy link
Owner

Does this really do something? bun.install --if-missing should already install bun.

@axelson
Copy link
Contributor Author

axelson commented Nov 20, 2024

mix bun.install installs _build/bun, mix bun install uses bun to install node_modules/

@LostKobrakai
Copy link
Owner

Ah, I was just wondering why this worked, but I had put this there xD Because it's mix bun PROFILE and I was wondering where the profile came from xD

@LostKobrakai LostKobrakai merged commit 35666ab into LostKobrakai:main Nov 20, 2024
1 check passed
@axelson axelson deleted the bun-install branch November 20, 2024 16:41
@axelson
Copy link
Contributor Author

axelson commented Nov 20, 2024

Yeah I had to look up how the profile worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants