Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cuda Graphs in CMakeList #947

Merged

Conversation

Nexesenex
Copy link

@Nexesenex Nexesenex commented Jun 27, 2024

Added by Slaren on LCPP after the recent refactor of LCPP.

ggerganov#8140

It must be for something (even if I saw the graphs in the KCPP logs already), so this PR allows to benefit from it now (or disable it!).

original LCPP PR 3242 by Slaren
@LostRuins
Copy link
Owner

This is actually incomplete and does not do anything. You need to add the compile definitions. I will merge it and fix it later.

@LostRuins LostRuins merged commit a5a32b9 into LostRuins:concedo_experimental Jun 29, 2024
@Nexesenex
Copy link
Author

Oh, I didn't understand either why there was no definition.
I missed to check into the other Cmakelists appeared with the refactor.
Apologies². At least it came to your attention. :P

@Nexesenex Nexesenex deleted the cuda_graphs_in_cmakelist branch July 11, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants