Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve notify_issue to be able to choose when the comment is created #29

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

LouisBrunner
Copy link
Owner

Resolves #28

@LouisBrunner LouisBrunner self-assigned this Dec 6, 2024
Copy link

sonarqubecloud bot commented Dec 6, 2024

Copy link

github-actions bot commented Dec 6, 2024

Smart Diff (Fails): Failure

Expected tolerance same but got worse instead

===================================================================
--- fixtures/file1_basic.txt
+++ fixtures/file2_deleted.txt
@@ -1,4 +1,3 @@
 A
-B
 C
 D

Copy link

github-actions bot commented Dec 6, 2024

Smart Diff (Works): Success

Check succeeded with tolerance better (expected same or better)

===================================================================
--- fixtures/file1_basic.txt
+++ fixtures/file4_added.txt
@@ -1,4 +1,5 @@
 A
 B
 C
 D
+E

Copy link

github-actions bot commented Dec 6, 2024

Smart Diff (Works (sticky)): Success

Check succeeded with tolerance better (expected same or better)

===================================================================
--- fixtures/file1_basic.txt
+++ fixtures/file4_added.txt
@@ -1,4 +1,5 @@
 A
 B
 C
 D
+E

Copy link

github-actions bot commented Dec 6, 2024

Smart Diff (Fails (sticky)): Failure

Expected tolerance same but got worse instead

===================================================================
--- fixtures/file1_basic.txt
+++ fixtures/file2_deleted.txt
@@ -1,4 +1,3 @@
 A
-B
 C
 D

@LouisBrunner LouisBrunner merged commit 9ea7b75 into main Dec 6, 2024
36 of 85 checks passed
@LouisBrunner LouisBrunner deleted the feat/comment-on branch December 6, 2024 14:03
WyriHaximus pushed a commit to WyriHaximus/github-workflows that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A way to not comment when the diff is successful
1 participant