-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jitter Classes (#249) #253
base: main
Are you sure you want to change the base?
Conversation
also i have NOT tested the new |
Spoke with @LouisDesdoigts and we (he) decided that the |
…s ratio of minor/major axes stdevs
Could even just rename the asymmetric jitter class to the new |
Yeah @maxecharles made a typo in his comment (GOT HIM), its just going to be called |
PR to track changes.
Adding the
ApplyAsymmetricJitter
class I wrote for TOLIMAN, parametrised byr
,phi
, andshear
.I basically completely rewrote the
generate_kernel
method in a way that seems a bit more intuitive to me:I kinda reimplemented this way of generating the kernel into the original
ApplyJitter
detector class.surely i become a real dLux contributor SURELY