Merge pull request #2865 from lewis6991/lint/cleanup

lint: cleanup unused code and redefined locals

.luarc.json

@@ -20,7 +20,8 @@
             "unused": "Any"
         },
         "ignoredFiles": "Opened",
-        "libraryFiles": "Opened"
+        "libraryFiles": "Opened",
+        "unusedLocalExclude": [ "_*" ]
     },
     "runtime": {
         "version": "Lua 5.4",

script/core/code-action.lua

@@ -1,13 +1,11 @@
 local files     = require 'files'
 local lang      = require 'language'
 local util      = require 'utility'
-local sp        = require 'bee.subprocess'
 local guide     = require "parser.guide"
 local converter = require 'proto.converter'
 local autoreq   = require 'core.completion.auto-require'
 local rpath     = require 'workspace.require-path'
 local furi      = require 'file-uri'
-local undefined = require 'core.diagnostics.undefined-global'
 local vm        = require 'vm'
 
 ---@param uri  uri
@@ -51,7 +49,7 @@ local function checkDisableByLuaDocExits(uri, row, mode, code)
     return nil
 end
 
-local function checkDisableByLuaDocInsert(uri, row, mode, code)
+local function checkDisableByLuaDocInsert(_uri, row, mode, code)
     return {
         start   = guide.positionOf(row, 0),
         finish  = guide.positionOf(row, 0),
@@ -242,7 +240,7 @@ local function solveSyntaxByFix(uri, err, results)
     }
 end
 
-local function solveSyntaxUnicodeName(uri, err, results)
+local function solveSyntaxUnicodeName(uri, _err, results)
     results[#results+1] = {
         title   = lang.script('ACTION_RUNTIME_UNICODE_NAME'),
         kind    = 'quickfix',
@@ -321,7 +319,7 @@ local function solveAmbiguity1(uri, diag, results)
     }
 end
 
-local function solveTrailingSpace(uri, diag, results)
+local function solveTrailingSpace(uri, _diag, results)
     results[#results+1] = {
         title = lang.script.ACTION_REMOVE_SPACE,
         kind = 'quickfix',
@@ -697,7 +695,7 @@ local function checkMissingRequire(results, uri, start, finish)
     end
 
     local function addRequires(global, endpos)
-        autoreq.check(state, global, endpos, function(moduleFile, stemname, targetSource)
+        autoreq.check(state, global, endpos, function(moduleFile, _stemname, _targetSource)
             local visiblePaths = rpath.getVisiblePath(uri, furi.decode(moduleFile))
             if not visiblePaths or #visiblePaths == 0 then return end
 

script/core/command/autoRequire.lua

@@ -1,6 +1,5 @@
 local files  = require 'files'
 local furi   = require 'file-uri'
-local config = require 'config'
 local rpath  = require 'workspace.require-path'
 local client = require 'client'
 local lang   = require 'language'

script/core/command/exportDocument.lua

@@ -2,7 +2,6 @@ local doc    = require 'cli.doc'
 local client = require 'client'
 local furi   = require 'file-uri'
 local lang   = require 'language'
-local ws     = require 'workspace'
 local files  = require 'files'
 
 ---@async

script/core/command/reloadFFIMeta.lua

@@ -32,7 +32,7 @@ return function (uri)
         return
     end
 
-    for i, v in ipairs(refs) do
+    for _, v in ipairs(refs) do
         local target_uri = v.uri
         local codes = searchCode(refs, target_uri)
         if not codes then

script/core/completion/completion.lua

@@ -448,7 +448,7 @@ local function checkModule(state, word, position, results)
     end)
 end
 
-local function checkFieldFromFieldToIndex(state, name, src, parent, word, startPos, position)
+local function checkFieldFromFieldToIndex(state, name, parent, word, position)
     if name:match(guide.namePatternFull) then
         if not name:match '[\x80-\xff]'
         or config.get(state.uri, 'Lua.runtime.unicodeName') then
@@ -499,7 +499,7 @@ local function checkFieldFromFieldToIndex(state, name, src, parent, word, startP
     return textEdit, additionalTextEdits
 end
 
-local function checkFieldThen(state, name, src, word, startPos, position, parent, oop, results)
+local function checkFieldThen(state, name, src, word, position, parent, oop, results)
     local value = vm.getObjectFunctionValue(src) or src
     local kind = define.CompletionItemKind.Field
     if (value.type == 'function' and not vm.isVarargFunctionWithOverloads(value))
@@ -542,7 +542,7 @@ local function checkFieldThen(state, name, src, word, startPos, position, parent
             newText = name:sub(#str[2] + 1, - #str[2] - 1),
         }
     else
-        textEdit, additionalTextEdits = checkFieldFromFieldToIndex(state, name, src, parent, word, startPos, position)
+        textEdit, additionalTextEdits = checkFieldFromFieldToIndex(state, name, parent, word, position)
     end
     results[#results+1] = {
         label      = name,
@@ -632,7 +632,7 @@ local function checkFieldOfRefs(refs, state, word, startPos, position, parent, o
     local fieldResults = {}
     for name, src in util.sortPairs(fields) do
         if src then
-            checkFieldThen(state, name, src, word, startPos, position, parent, oop, fieldResults)
+            checkFieldThen(state, name, src, word, position, parent, oop, fieldResults)
             await.delay()
         end
     end
@@ -1256,12 +1256,10 @@ local function insertDocEnum(state, pos, doc, enums)
     return enums
 end
 
----@param state     parser.state
----@param pos       integer
 ---@param doc       vm.node.object
 ---@param enums     table[]
 ---@return table[]?
-local function insertDocEnumKey(state, pos, doc, enums)
+local function insertDocEnumKey(doc, enums)
     local tbl = doc.bindSource
     if not tbl then
         return nil
@@ -1357,12 +1355,12 @@ local function insertEnum(state, pos, src, enums, isInArray, mark)
     elseif src.type == 'doc.enum' then
         ---@cast src parser.object
         if vm.docHasAttr(src, 'key') then
-            insertDocEnumKey(state, pos, src, enums)
+            insertDocEnumKey(src, enums)
         else
             insertDocEnum(state, pos, src, enums)
         end
     elseif isInArray and src.type == 'doc.type.array' then
-        for i, d in ipairs(vm.getDefs(src.node)) do
+        for _, d in ipairs(vm.getDefs(src.node)) do
             insertEnum(state, pos, d, enums, isInArray, mark)
         end
     elseif src.type == 'global' and src.cate == 'type' then
@@ -2082,7 +2080,7 @@ local function tryluaDocByErr(state, position, err, docState, results)
         end
         local label = {}
         local insertText = {}
-        for i, arg in ipairs(func.args) do
+        for _, arg in ipairs(func.args) do
             if arg[1] and arg.type ~= 'self' then
                 label[#label+1] = arg[1]
                 if #label == 1 then
@@ -2098,7 +2096,7 @@ local function tryluaDocByErr(state, position, err, docState, results)
             insertTextFormat = 2,
             insertText       = table.concat(insertText, '\n'),
         }
-        for i, arg in ipairs(func.args) do
+        for _, arg in ipairs(func.args) do
             if arg[1] then
                 results[#results+1] = {
                     label  = arg[1],

script/core/completion/keyword.lua

@@ -1,5 +1,4 @@
 local define     = require 'proto.define'
-local files      = require 'files'
 local guide      = require 'parser.guide'
 local config     = require 'config'
 local util       = require 'utility'

script/core/definition.lua

@@ -59,7 +59,7 @@ local accept = {
     ['doc.field.name']   = true,
 }
 
-local function checkRequire(source, offset)
+local function checkRequire(source)
     if source.type ~= 'string' then
         return nil
     end
@@ -141,14 +141,14 @@ return function (uri, offset)
     local results = {}
     local uris = checkRequire(source)
     if uris then
-        for i, uri in ipairs(uris) do
+        for _, uri0 in ipairs(uris) do
             results[#results+1] = {
-                uri    = uri,
+                uri    = uri0,
                 source = source,
                 target = {
                     start  = 0,
                     finish = 0,
-                    uri    = uri,
+                    uri    = uri0,
                 }
             }
         end

script/core/diagnostics/cast-type-mismatch.lua

@@ -1,5 +1,4 @@
 local files   = require 'files'
-local guide   = require 'parser.guide'
 local lang    = require 'language'
 local vm      = require 'vm'
 local await   = require 'await'

script/core/diagnostics/different-requires.lua

@@ -1,7 +1,6 @@
 local files   = require 'files'
 local guide   = require 'parser.guide'
 local lang    = require 'language'
-local config  = require 'config'
 local vm      = require 'vm'
 local rpath   = require 'workspace.require-path'
 

script/core/diagnostics/duplicate-set-field.lua

@@ -1,6 +1,5 @@
 local files    = require 'files'
 local lang     = require 'language'
-local define   = require 'proto.define'
 local guide    = require 'parser.guide'
 local vm       = require 'vm'
 local await    = require 'await'
@@ -24,7 +23,6 @@ local function getTopFunctionOfIf(source)
         end
         source = source.parent
     end
-    return nil
 end
 
 ---@async

script/core/diagnostics/missing-fields.lua

@@ -35,7 +35,7 @@ return function (uri, callback)
                 return
             end
         end
-        
+
         local myKeys
         local warnings = {}
         for className, samedefs in pairs(sortedDefs) do
@@ -44,7 +44,7 @@ return function (uri, callback)
                 if not def.fields or #def.fields == 0 then
                     goto continue
                 end
-                
+
                 if not myKeys then
                     myKeys = {}
                     for _, field in ipairs(src) do
@@ -82,7 +82,7 @@ return function (uri, callback)
             if #missedKeys == 0 then
                 return
             end
-            
+
             warnings[#warnings+1] = lang.script('DIAG_MISSING_FIELDS', className, table.concat(missedKeys, ', '))
         end
 

script/core/diagnostics/missing-local-export-doc.lua

@@ -41,7 +41,7 @@ return function (uri, callback)
         await.delay()
         --table
 
-        for i, ret in ipairs(source) do
+        for _, ret in ipairs(source) do
             if ret.type == 'getlocal' then
                 if ret.node.value and ret.node.value.type == 'table' then
                     findSetField(state.ast, ret[1], callback)

script/core/diagnostics/param-type-mismatch.lua

@@ -32,9 +32,8 @@ end
 
 ---@param funcNode vm.node
 ---@param i integer
----@param uri uri
 ---@return vm.node?
-local function getDefNode(funcNode, i, uri)
+local function getDefNode(funcNode, i)
     local defNode = vm.createNode()
     for src in funcNode:eachObject() do
         if src.type == 'function'
@@ -93,7 +92,7 @@ return function (uri, callback)
             if not refNode then
                 goto CONTINUE
             end
-            local defNode = getDefNode(funcNode, i, uri)
+            local defNode = getDefNode(funcNode, i)
             if not defNode then
                 goto CONTINUE
             end

script/core/diagnostics/unbalanced-assignments.lua

@@ -1,5 +1,4 @@
 local files  = require 'files'
-local define = require 'proto.define'
 local lang   = require 'language'
 local guide  = require 'parser.guide'
 local await  = require 'await'
@@ -13,7 +12,7 @@ local types = {
 }
 
 ---@async
-return function (uri, callback, code)
+return function (uri, callback)
     local ast = files.getState(uri)
     if not ast then
         return

script/core/diagnostics/undefined-global.lua

@@ -1,10 +1,7 @@
 local files     = require 'files'
 local vm        = require 'vm'
 local lang      = require 'language'
-local config    = require 'config'
 local guide     = require 'parser.guide'
-local await     = require 'await'
-local util      = require 'utility'
 
 local requireLike = {
     ['include'] = true,

script/core/diagnostics/unknown-cast-variable.lua

@@ -1,5 +1,4 @@
 local files   = require 'files'
-local guide   = require 'parser.guide'
 local lang    = require 'language'
 local vm      = require 'vm'
 local await   = require 'await'

script/core/diagnostics/unknown-operator.lua

@@ -1,9 +1,6 @@
 local files   = require 'files'
-local guide   = require 'parser.guide'
 local lang    = require 'language'
 local vm      = require 'vm'
-local await   = require 'await'
-local util    = require 'utility'
 
 ---@async
 return function (uri, callback)