Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type narrow on fields with multiple literals #2871

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

lewis6991
Copy link
Contributor

@lewis6991 lewis6991 commented Sep 25, 2024

This shouldn't need a changelog entry since there hasn't been a release since the bug was introduced.

@lewis6991 lewis6991 changed the title fix/narrowlit fix: type narrow on fields with multiple literals Sep 25, 2024
@lewis6991
Copy link
Contributor Author

Looks like something as broken CI. The project can't even checkout.

@clason
Copy link

clason commented Sep 28, 2024

@sumneko could you rerun CI? This looks like Github broke (briefly).

@tomlau10
Copy link
Contributor

tomlau10 commented Sep 28, 2024

maybe @lewis6991 can try amending and do a force push, it shall retrigger the CI
(say changing the commit msg or something else, which makes the commit hash different)

@carsakiller
Copy link
Collaborator

Just re-ran failed jobs 🙂

@sumneko
Copy link
Collaborator

sumneko commented Sep 29, 2024

Thank you!

@sumneko sumneko merged commit b9faa87 into LuaLS:master Sep 29, 2024
10 of 11 checks passed
@lewis6991 lewis6991 deleted the fix/narrowlit branch September 29, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants