Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter .DS_Store file from addons list #147

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

Patman12
Copy link
Contributor

The Addon Manager stopped working after a .DS_Store file popped up in the addons directory, indicating the following error:

[2024-08-27 21:02:37] | ERROR | Filesystem | Error: ENOTDIR: not a directory, stat '/Users/<user>/Library/Application Support/Code/User/globalStorage/sumneko.lua/addonManager/addons/.DS_Store/module'

Tested after adding the code change and verified Addon Manager successfully loaded.

@sumneko
Copy link
Collaborator

sumneko commented Aug 28, 2024

Please resolve the compiling fails

Copy link
Collaborator

@carsakiller carsakiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be best to ignore .DS_Store during addon discovery rather than addon listing.

@carsakiller
Copy link
Collaborator

@Patman12 please check that this properly ignores .DS_Store on Mac 🙂

@Patman12
Copy link
Contributor Author

@carsakiller just verified your update and made a minor update to check existence of addons after filtering .DS_Store

@carsakiller carsakiller merged commit e418c6a into LuaLS:master Sep 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants