feat(ytmusic): Add support for YouTube Music mood filters #404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #297
Proposed changes
filters
property andapplyFilter
method toytmusic.HomeFeed
, which allows results to be filtered by mood.Testing
Notes
HomeFeed.applyFilter
is almost exactly the same asSearch.applyFilter
. I'd like to avoid this code duplication by using an inherited base class in theytmusic
classes. I think this would also provide some structure to the classes in this directory, as they implement the same kinds of methods e.g.has_continuation
,getContinuation
,applyFilter
,filters
... However I didn't want to make an invasive change without discussion.