Use node 18 on Pull Request Checks #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MSW library has an issue with the most recent Node version
20.12.x, which makes the test fail when trying to access theserver.listen();method as shown here. So to pass the tests locally, ensure you are running a compatible node version (>= 18 and <= 20.9.0).The PR Checks workflow started to fail on GitHub Actions due to the new runner version
v2.315.0that enforces node 20, as per this commit. This PR updates the workflow to enforce the use of node 18 following the same config as per MSW repo workflows.