perf: prepend POSIX utilities with command -p
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepending POSIX-guaranteed utilities with `command -p` instead of just `command` is more dependable. It provides mroe replicability by avoiding potentially hazardous calls to less secure aliases and symbolic links. Fix #41 Signed-off-by: Lucas Larson <LucasLarson@riseup.net>
`command -p -- awk -F '\t' -- '{$2 $1}'` creates a false positive SC2016 error in Shellcheck v0.9.0
`command awk -F '\t' -- '{$2 $1}'`, which is identical in function, causes no such error
Because it appears that any command that begins `command -p` and contains a single-quoted dollar sign is incorrectly considered an SC2016 error in Shellcheck v0.9.0, this commit replaces the `awk` program with a `sed` command which also provides identical functionality:
`command -p -- sed -e 's/\(.*\)\t\(.*\)/\2\1/'`
Signed-off-by: Lucas Larson <LucasLarson@riseup.net>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepending POSIX-guaranteed utilities with
command -pinstead of justcommandis more dependable. It provides mroe replicability by avoiding potentially hazardous calls to less secure aliases and symbolic links and will fix #41.