Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature of CodeNotary #84

Closed
wants to merge 1 commit into from
Closed

Signature of CodeNotary #84

wants to merge 1 commit into from

Conversation

cociweb
Copy link
Collaborator

@cociweb cociweb commented Dec 3, 2023

Sign the add-on with CodeNotary.
It addresses #83.

Sign the add-on with CodeNotary.
@cociweb cociweb changed the title Signature of CodeNotary (#83) Signature of CodeNotary Dec 3, 2023
@tjorim
Copy link
Collaborator

tjorim commented Dec 3, 2023

While the base image is correct, we currently don't sign the add-on yet (and we would need to use our own email address). I think we also need to adjust the GitHub actions.

@tjorim
Copy link
Collaborator

tjorim commented Dec 3, 2023

As far as I know they are also moving away from codenotary. They're now relying on cosign.

@LukasGrebe
Copy link
Owner

To complete the chain of trust we would also need to verify the ebusd image we use (I'm not sure if it even gets signed) and verify the base image.

@cociweb
Copy link
Collaborator Author

cociweb commented Dec 3, 2023

Well, the developer site is not mention cosign, so the recemmended (at least by docs) is the codenotary. (BTW, I've seen some cosign instruction in some further repos, but it has not been in the documentation set, yet. So maybe some background activity is on it's way about this question, but not officially.)

The related part is here, where the the base image can refer to the HA's. maybe the 'own mail' is not required or just notification is sent to a registered mail?? - I'm not really aware of the exact mechanism of the signing.

At this point, If you think, the PR/issue is unnecessary, than we can revoke it..

@tjorim tjorim marked this pull request as draft December 4, 2023 08:59
@tjorim
Copy link
Collaborator

tjorim commented Dec 4, 2023

I marked this as draft right now. Codenotary CAS (https://cas.codenotary.com/) has been down for a while now so we can not sign it at the moment. It will be replaced by cosign but it's not implemented yet (checked with some devs on the discord server).

@LukasGrebe
Copy link
Owner

closed as stale

@LukasGrebe LukasGrebe closed this Jul 1, 2024
@tjorim tjorim deleted the cociweb-codenotary branch July 1, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants