Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more snippets #59

Merged
merged 2 commits into from
Dec 1, 2017
Merged

Added more snippets #59

merged 2 commits into from
Dec 1, 2017

Conversation

lgarcin
Copy link
Contributor

@lgarcin lgarcin commented Nov 30, 2017

No description provided.

@lgarcin lgarcin mentioned this pull request Nov 30, 2017
'tip directive':
'prefix': 'tip'
'body': '.. tip::\n\n\t'
'topic directive':

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you consider adding this snippet for the toctree directive

  'toctree directive':
    'prefix': 'toctree'
    'body': '.. toctree::\n\t:maxdepth: ${1:2}\n\n\t$0'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👆 What he said.

Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 😀 If you could fix what I pointed out and add the toctree snippet, I'll get this merged.

'body': '.. compound::\n\n\t'
'container directive':
'prefix': 'container'
'body': '.. container:: {$1:class}\n\n\t$0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo on this line. 😉 It should be ${, not {$.

'body': '.. tip::\n\n\t'
'topic directive':
'prefix': 'topic'
'body': '.. topic## $1{1:title}'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo on this line too: $1{1 should simply be ${1

'body': ':ref:`$0`'
'menuselection role':
'prefix': 'menuselection'
'body': ':menuselection:`${1:menu item} --> {$2:submenu item}`'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here: {$2:${2:

'tip directive':
'prefix': 'tip'
'body': '.. tip::\n\n\t'
'topic directive':
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👆 What he said.

Fixed several typos.
Added :
- toctree directive
- plot directive (matplotlib)
- bokeh-plot directive (bokeh)
@lgarcin
Copy link
Contributor Author

lgarcin commented Dec 1, 2017

Done. Thanks for the review.

@Alhadis Alhadis merged commit ed60b39 into Lukasa:master Dec 1, 2017
@Alhadis
Copy link
Collaborator

Alhadis commented Dec 1, 2017

Thanks!

I'll strive to get a release cut as soon as possible, which is easier said than done since my MacBook died the other night, and I'm currently Atom-less...😣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants