-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more snippets #59
Conversation
'tip directive': | ||
'prefix': 'tip' | ||
'body': '.. tip::\n\n\t' | ||
'topic directive': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you consider adding this snippet for the toctree
directive
'toctree directive':
'prefix': 'toctree'
'body': '.. toctree::\n\t:maxdepth: ${1:2}\n\n\t$0'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👆 What he said.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 😀 If you could fix what I pointed out and add the toctree
snippet, I'll get this merged.
'body': '.. compound::\n\n\t' | ||
'container directive': | ||
'prefix': 'container' | ||
'body': '.. container:: {$1:class}\n\n\t$0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo on this line. 😉 It should be ${
, not {$
.
'body': '.. tip::\n\n\t' | ||
'topic directive': | ||
'prefix': 'topic' | ||
'body': '.. topic## $1{1:title}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo on this line too: $1{1
should simply be ${1
'body': ':ref:`$0`' | ||
'menuselection role': | ||
'prefix': 'menuselection' | ||
'body': ':menuselection:`${1:menu item} --> {$2:submenu item}`' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here: {$2:
➡ ${2:
'tip directive': | ||
'prefix': 'tip' | ||
'body': '.. tip::\n\n\t' | ||
'topic directive': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👆 What he said.
Fixed several typos. Added : - toctree directive - plot directive (matplotlib) - bokeh-plot directive (bokeh)
Done. Thanks for the review. |
Thanks! I'll strive to get a release cut as soon as possible, which is easier said than done since my MacBook died the other night, and I'm currently Atom-less...😣 |
No description provided.