Add .liquid suffix to all Cargo.toml in the project template #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users reported that
cargo
complains about the Cargo.toml files in the project template when installing thepavexc
orpavex
CLI from source:These are warnings, they don't cause the installation to fail.
Based on my investigation, it might related to
cargo
's behaviour when installing from agit
source: it doesn't let you specify the relative path to the Cargo.toml of the package you want to install; it scans the entire repository until it finds a package that matches. Those warnings might be a byproduct of that scan.I haven't checked
cargo
's source code to confirm my theory, but this is an easy change to make and we can verify if it works.