Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature gate tokio net feature for pavex behind server feature #324

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

benwis
Copy link
Contributor

@benwis benwis commented Jul 2, 2024

To aid in wasm dependency resolution for the pavex crate, I've moved the net feature for tokio behind the server flag

@LukeMathWalker
Copy link
Owner

This works nicely, but I think we want to check in CI that pavex compiles to WASM with default features disabled—that's the actual property we want to enforce.

@LukeMathWalker LukeMathWalker merged commit 4446869 into LukeMathWalker:main Jul 15, 2024
9 checks passed
@pavex-releaser pavex-releaser bot mentioned this pull request Jul 27, 2024
LukeMathWalker pushed a commit that referenced this pull request Jul 27, 2024
## 🤖 New release
* `pavex`: 0.1.45 -> 0.1.46
* `pavex_bp_schema`: 0.1.45 -> 0.1.46
* `pavex_reflection`: 0.1.45 -> 0.1.46
* `pavex_macros`: 0.1.45 -> 0.1.46
* `persist_if_changed`: 0.1.45 -> 0.1.46
* `pavex_tracing`: 0.1.45 -> 0.1.46
* `pavex_cli`: 0.1.45 -> 0.1.46
* `pavex_miette`: 0.1.45 -> 0.1.46
* `pavexc_cli_client`: 0.1.45 -> 0.1.46
* `pavexc`: 0.1.45 -> 0.1.46
* `pavex_cli_client`: 0.1.45 -> 0.1.46
* `pavexc_cli`: 0.1.45 -> 0.1.46
* `generate_from_path`: 0.1.45 -> 0.1.46

<details><summary><i><b>Changelog</b></i></summary><p>

## `pavex`
<blockquote>

##
[0.1.46](0.1.45...0.1.46)
- 2024-07-27

### Other
- Disable workspace hack before a release
- Re-enable workspace hack after a release
([#323](#323))
- Feature gate tokio net feature for pavex behind server feature
([#324](#324))
- update Cargo.toml dependencies
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: pavex-releaser[bot] <ci@pavex.dev>
Co-authored-by: pavex-releaser[bot] <167640712+pavex-releaser[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants