Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usePolling to sass watch #198

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Conversation

justafish
Copy link
Member

@justafish justafish commented Apr 13, 2023

The Chokidar version is old and broken on Macs gulpjs/glob-watcher#49

To test:

  • 'yarn unplug @lullabot/drainpipe-sass`
  • Replace .yarn/unplugged/@lullabot-drainpipe-sass-npm<some other stuff>/node_modules/@lullabot/drainpipe-sass with the new gulpfile.js and package.json
  • Run ddev yarn
  • Try and save a file multiple times and see if sass watch picks up on it

Copy link

@pjudge pjudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOOOOOO!

@deviantintegral
Copy link
Member

The Chokidar version is old and broken on Macs gulpjs/glob-watcher#49

Hm. So with ddev and mutagen on macs, the watcher runs inside of linux, and therefore uses inotify?

Does upgrading Chokidar without turning on usePolling fix things too?

@justafish
Copy link
Member Author

whilst I could override it to upgrade it on an individual project level, the issue is the dependencies of glob-watcher, so we'd have to fork it

@justafish justafish merged commit d9a09ae into main Apr 13, 2023
@justafish justafish deleted the justafish/use-polling-sass-watch branch April 13, 2023 14:18
@mtift
Copy link

mtift commented Apr 13, 2023

Yahoooooooo! Thank you @justafish and @pjudge and @deviantintegral !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants