Fixes PHPStan configuration #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-2
to
+3
| - vendor/lullabot/drainpipe-dev/config/phpstan.neon | ||
| - ../../../mglaman/phpstan-drupal/extension.neon | ||
| - ../../../phpstan/phpstan-deprecation-rules/rules.neon |
There was a problem hiding this comment.
@justafish what's the reason for changing these? Will the previously shipped phpstan.neon be removed in drainpipe 4? Wondering what your recommendations are for sites that have customized this file.
| if [ "{{.format}}" == "junit" ]; then | ||
| mkdir -p test_result | ||
| ./vendor/bin/phpstan analyse --error-format=junit {{.TEST_DIRS}} > test_result/phpstan.xml | ||
| ./vendor/bin/phpstan analyse --error-format=junit -c $CONFIG {{.TEST_DIRS}} > test_result/phpstan.xml |
There was a problem hiding this comment.
@justafish This change broke a site that had a phpstan.neon.dist file. Since -c is being used, this skips the default behaviour documented at https://phpstan.org/config-reference:
If you do not provide a config file explicitly, PHPStan will look for files named phpstan.neon, phpstan.neon.dist, or phpstan.dist.neon in the current directory.
Two thoughts:
- Could we instead copy to phpstan.neon.dist? That would reserve
phpstan.neonfor locals and other customized environments, matching phpunit behaviour. - If phpstan.neon(.dist) has been excluded form the scaffold via composer.json, then should we just abort the test with a warning and say "phpstan isn't configured"? I'm trying to figure out why the default case here would be triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.