-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#150 wait for Pantheon deployment #395
Conversation
b55e475
to
c855884
Compare
I have yet to test this with a deployment. |
@beto-aveiga I believe we have the Test GitHub Actions workflow doing this for us. Here's an example build that passed where it builds and pushes to Pantheon MultiDev. We may still want to check out this branch on a project where we've had this job flaky failing due to MultiDev timeouts. Ping me in Slack and I'll let you know which project that is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment at #159 (comment) as this is still fragile if deployments take longer than 5 minutes. Terminus has a plugin command we can use that handles all of the waiting and retry logic for us.
I will work on it. Thanks! |
Looks like the version of Drush we're running might not have the command that @deviantintegral suggested.
Nevermind! It looks like we would get this command when terminus-build-tools extension gets added as @deviantintegral mentioned in the comment.
|
Description
Improves the waiting mechanism after a deployment to Pantheon.
pending
orsucceeded
.succeeded
, the script continues as usual.Related issue
#159