Do not force to scaffold Nightwatch.gitlab-ci.yml #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plopesc
changed the title
|
@plopesc thanks! Could you update the documentation to explain how to bring this file in going forward? As it's a breaking change it'll need a major release |
|
@justafish Added a very basic doc regarding the mentioned file. I checked #351 to get a better understanding of the needs that new file tries to cover but I was unable to get a better picture. Let me know if you think that documentation is good enough or needs any improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all the projects require the Nightwatch.gitlab-ci.yml file.
In fact, in our case, pipelines are broken when this file is included because we get this error in Gitlab.
Having this file optional and only installed if declared in the composer.json specific section like the rest of gitlab scaffolding files would avoid this error.
Thank you