ISSUE-370: composer configuration checks

[beto-aveiga]

relates to: #370

It adds the following checks when running composer install.

https://architecture.lullabot.com/adr/20220429-composer-patchlevel/
https://architecture.lullabot.com/adr/20220429-composer-patches-inline/
https://architecture.lullabot.com/adr/20220429-composer-patch-files/
https://architecture.lullabot.com/adr/20220429-composer-exit-failure/

It also adds a test for the checks.

Screenshots

[mrdavidburns]

I approve this feature!

[mrdavidburns]

This is a great addition that aligns with our ADR: Use local copies of patch files

I know we have completely updated all our projects to adhere to this, so having a check that will enforce this would be a nice addition.

[justafish]

Very cool!

Could we have this on by default and allow an opt-out?

[deviantintegral]

This is great! I love codifying our ADRs like this 👏 .

I wonder if it's worth moving this to a new plugin class. The other code in this class is installing scaffold files, while this is validating composer which feels like a different concern.

[deviantintegral]

I don't think we need to prefix these with an underscore - they're private methods?

[beto-aveiga]

I got a VSCode hint when I started moving the code to the Drainpipe repo branch, and I thought it was a coding standard in the Drainpipe project. It is probably just a misconfiguration on my IDE. I will remove the _ from the checks I created.

[beto-aveiga]

@justafish Could we have this on by default and allow an opt-out?

Opt-out using composer configuration in the "extra" section? Do you mean something like this?

[beto-aveiga]

@deviantintegral I wonder if it's worth moving this to a new plugin class. The other code in this class is installing scaffold files, while this is validating composer which feels like a different concern.

I think the answer is yes. Definitely.
I will create a ComposerChecksPlugin class.

[beto-aveiga]

If tests pass, the only thing missing is the opt-out configuration. #717 (review)

[beto-aveiga]

I also added documentation for the opt-out configurations.

[beto-aveiga]

Added tests for the opt-out options.

[justafish]

@beto-aveiga - @deviantintegral and I discussed this and we think it'd be really cool to have as a separate project as it doesn't necessarily need Drupal. We can then pull it into Drainpipe as a requirement. We've created a repo for you here and invited you: https://github.com/Lullabot/composer-checks

Thanks!