Add ASCII View to Rosalina Process List #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to view the memory of a process interpreted as ASCII characters. I've also added some new info text, that appears in place of the switch-between-heap-and-code text when only only one of the heap or text is available, originally I wanted to have it always be shown, but I felt like that might take too much space away from viewing the memory itself. This coincidentally also solves the problem of the memory dump not filling the screen when only one of the heap or code is present.
Here we're viewing the memory of the SSL process and can see the text "Nintendo of America Inc." among others
Here's what the new info text looks like
(Sorry for the pictures I don't know how to screenshot Rosalina)