feat(library-management): add h5p-library-management to settings #1416
Conversation
JPSchellenberg
added
the
[type] feature
|
This PR can be reviewed as soon as #1433 is merged into master and this branch. |
|
Great job! My usual nitpicky remarks: ;) The left margin of the settings dialog content is incorrect if the window isn't very wide: The color of the "upload and install library" button is unusual. If you delete a library, it's still in the list. The list should be updated. It would be useful do display an indication why many libraries can't be deleted, e.g. a lock symbol with a hover text ("cannot be delted, because it is used in ... other libraries"). |
Thank you, but the most code is from you :D
They are great.. I miss a lot of those things as I am too focused on other things.. So PR Review do actually make a lot of sense. |
|
Looks good! We should first merge in #1443 and then auto-localize the locales to avoid merge conflicts in all the language files. The "Installed H5P libraries" title is fixed and doesn't scroll: (always hovers at the same position) The margin between the details button and the delete/disabled button should be bigger: |
…at/library-management
# [0.7.0](v0.6.1...v0.7.0) (2021-04-17) ### Bug Fixes * **analytics:** improve error-handling ([#1443](#1443)) ([287c675](287c675)) * **analytis:** increase search bar to fit text ([c146247](c146247)) * **cancelExport:** use cancelExportH5P-action consistently ([d0dc8c7](d0dc8c7)) * **client:** updated Spanish locales ([8e1111a](8e1111a)) * **deps:** update dependency @testing-library/user-event to v13.1.2 ([d7d3561](d7d3561)) * **deps:** update dependency @testing-library/user-event to v13.1.3 ([26520b9](26520b9)) * **deps:** update dependency @types/node to v14.14.39 ([97236f2](97236f2)) * **deps:** update dependency @types/node to v14.14.41 ([cd7d325](cd7d325)) * **deps:** update dependency classnames to v2.3.1 ([d94d87c](d94d87c)) * **deps:** update dependency electron-log to v4.3.3 ([2358356](2358356)) * **deps:** update dependency electron-log to v4.3.4 ([9646ffc](9646ffc)) * **deps:** update dependency i18next to v20.2.0 ([0470714](0470714)) * **deps:** update dependency i18next to v20.2.1 ([e5148a4](e5148a4)) * **deps:** update dependency i18next-http-middleware to v3.1.1 ([a344d1c](a344d1c)) * **deps:** update dependency react-i18next to v11.8.13 ([b6eb1b3](b6eb1b3)) * **deps:** update dependency typescript to v4.2.4 ([80077f8](80077f8)) * **devmode:** empty --libs switch ignored ([9fa6e3b](9fa6e3b)) * **devmode:** pass undefined if libs is not set ([b5e91a7](b5e91a7)) * **general:** added missing default Mac menu ([d3388e2](d3388e2)) * **i18n:** Translated using Weblate (Spanish (Mexico) (es_MX)) ([#1447](#1447)) ([653410e](653410e)) * **locales:** auto-translated new strings ([02552ce](02552ce)) * **locales:** corrected auto-translated German locale ([8b3bbc7](8b3bbc7)) * **locales:** run autotranslation ([5dde3e1](5dde3e1)) * **locales:** Translations update from Weblate ([88456da](88456da)) * **mac-menu:** missing default mac-menu ([961abbf](961abbf)) * **merge:** fixed incorrect merge ([5739f6d](5739f6d)) * **sentry:** add new DSN ([#1438](#1438)) ([0228646](0228646)) * **server:** improved file dialogs ([5b13df9](5b13df9)) * **settings:** overhaul settings layout ([#1412](#1412)) ([cb513cd](cb513cd)) ### Features * **auth:** add auth via passwordless login & register ([#1410](#1410)) ([d5e31af](d5e31af)) * **client:** added cancel to export dialog ([843e3cd](843e3cd)) * **client:** added export options ([2c7379b](2c7379b)) * **client+server:** added SCORM mastery score ([6952d5b](6952d5b)) * **editor:** content type names in tab headers now localized ([#1419](#1419)) ([eed23e8](eed23e8)) * **editor:** dev mode ([#1432](#1432)) ([d6035e5](d6035e5)) * **exports:** added more export options ([1d9c95b](1d9c95b)) * **exports:** updated locales ([f2b6bf7](f2b6bf7)) * **library-management:** add h5p-library-management to settings ([#1416](#1416)) ([1e83648](1e83648)) * **mac menu:** added localization ([9d2917a](9d2917a)) * **server:** changed export ([0311a34](0311a34)) * **server:** external export works ([b892d1f](b892d1f)) * **server:** first functional SCORM exporter ([2ffd2f5](2ffd2f5)) * **server+client:** localized export ([3e65a45](3e65a45))
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.