Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Sentakki Editor #75

Closed
wants to merge 44 commits into from
Closed

Implement Sentakki Editor #75

wants to merge 44 commits into from

Commits on Jun 23, 2020

  1. Initial implementation of editor

    @LumpBloom7
    LumpBloom7 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    64672fc View commit details
    Browse the repository at this point in the history

  2. Add Tap to toolbox

    @LumpBloom7
    LumpBloom7 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    a7ca772 View commit details
    Browse the repository at this point in the history

  3. Get basic selection in a functional state

    @LumpBloom7
    LumpBloom7 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    e3d30f4 View commit details
    Browse the repository at this point in the history

  4. Make select tool select stuff in a more sensible way 

    Since the hitarea is detached from the note visuals, it makes selecting very odd.
    @LumpBloom7
    LumpBloom7 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    1c43960 View commit details
    Browse the repository at this point in the history

  5. Account for animation duration in ShouldBeAlive check 

    Avoids an issue where notes can be selected before they first become visible
    @LumpBloom7
    LumpBloom7 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    e214b1d View commit details
    Browse the repository at this point in the history

  6. Improve Tap note selection highlight

    @LumpBloom7
    LumpBloom7 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    defa58d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into Editor

    @LumpBloom7
    LumpBloom7 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    c8000db View commit details
    Browse the repository at this point in the history

  8. Allow selection of HOLDs in editor

    @LumpBloom7
    LumpBloom7 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    2a8e5f3 View commit details
    Browse the repository at this point in the history

  9. Fix selection boundaries not being correct 

    In the SSDQ, TopLeft may not actually be the top left, and the SelectionHandler doesn't safely handle such cases.

To resolve this, a function is used to make sure everything is correct before it goes down the chain.
    @LumpBloom7
    LumpBloom7 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    98cf2a0 View commit details
    Browse the repository at this point in the history

  10. Make all selections use osu Yellow

    @LumpBloom7
    LumpBloom7 committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    5bcd85e View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Implement Hold composition tool

    @LumpBloom7
    LumpBloom7 committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    ea254a4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into Editor

    @LumpBloom7
    LumpBloom7 committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    61515d9 View commit details
    Browse the repository at this point in the history

  3. Fix formatting

    @LumpBloom7
    LumpBloom7 committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    1cca321 View commit details
    Browse the repository at this point in the history

  4. Add TouchHold selection blueprint

    @LumpBloom7
    LumpBloom7 committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    f8d6f43 View commit details
    Browse the repository at this point in the history

  5. Improve selection boundaries 

    Use the selection pieces' SSDQ as the selection quad

The HOLD selection is using a rotated SSDQ, so it has to be converted to an Rectanglef (which makes sure everything is the right way up). It is shrunk so that the quad size appears roughly the same to the other quads
    @LumpBloom7
    LumpBloom7 committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    789ad12 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Implement TouchHold placement blueprint

    @LumpBloom7
    LumpBloom7 committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    05c2ad3 View commit details
    Browse the repository at this point in the history

  2. Fix potential division by 0 error that could happen with TouchHolds

    @LumpBloom7
    LumpBloom7 committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    262f6ec View commit details
    Browse the repository at this point in the history

  3. Add custom selection handler 

    Changes the Angle variable into a bindable, so that visual jank is avoided. Looking to change this in another PR.
    @LumpBloom7
    LumpBloom7 committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    0a3269b View commit details
    Browse the repository at this point in the history

  4. Some cleanups

    @LumpBloom7
    LumpBloom7 committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    f0604af View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2020

  1. Implement Touch placement and selection blueprint

    @LumpBloom7
    LumpBloom7 committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    d4ffdd3 View commit details
    Browse the repository at this point in the history

  2. Implement selection handler for Touch notes

    @LumpBloom7
    LumpBloom7 committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    fa0e08e View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Merge branch 'master' into Editor

    @LumpBloom7
    LumpBloom7 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    ebd4d12 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2020

  1. Merge branch 'master' into Editor

    @LumpBloom7
    LumpBloom7 committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    be59480 View commit details
    Browse the repository at this point in the history

  2. Accommodate new angle extension

    @LumpBloom7
    LumpBloom7 committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    6202c3d View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2020

  1. Fix placement blueprints using the wrong angles

    @LumpBloom7
    LumpBloom7 committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    b5757c2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into Editor

    @LumpBloom7
    LumpBloom7 committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    f5bae4d View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. Remove license header

    @LumpBloom7
    LumpBloom7 committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    873a262 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. Merge branch 'master' into Editor

    @LumpBloom7
    LumpBloom7 committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    9c4605a View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2020

  1. Merge branch 'master' into Editor

    @LumpBloom7
    LumpBloom7 committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    a825197 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. Merge branch 'master' into Editor

    @LumpBloom7
    LumpBloom7 committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    8f7d69a View commit details
    Browse the repository at this point in the history

  2. Begin implementing SlideCompositionTool

    @LumpBloom7
    LumpBloom7 committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    2ee160d View commit details
    Browse the repository at this point in the history

  3. Initial implementation of the SlideBody highlight

    @LumpBloom7
    LumpBloom7 committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    a94cd8b View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. SlideSelectionStar should rotate alongside hitobject

    @LumpBloom7
    LumpBloom7 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    20db863 View commit details
    Browse the repository at this point in the history

  2. Made SlideEditBody border radius larger

    @LumpBloom7
    LumpBloom7 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    30ed39c View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2020

  1. Merge branch 'master' into Editor

    @LumpBloom7
    LumpBloom7 committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    a8fd7bb View commit details
    Browse the repository at this point in the history

  2. Add icons for composition tools

    @LumpBloom7
    LumpBloom7 committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    0936d75 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2020

  1. Merge branch 'master' into Editor

    @LumpBloom7
    LumpBloom7 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    845be8b View commit details
    Browse the repository at this point in the history

  2. Fix slides not immediately reverting

    @LumpBloom7
    LumpBloom7 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    af68bfe View commit details
    Browse the repository at this point in the history

  3. Add break toggle to context menu

    @LumpBloom7
    LumpBloom7 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    acbb029 View commit details
    Browse the repository at this point in the history

  4. Remove new combo option in side menu

    @LumpBloom7
    LumpBloom7 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    3319e25 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2020

  1. Add basic pattern selection of slides

    @LumpBloom7
    LumpBloom7 committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    8ffb113 View commit details
    Browse the repository at this point in the history

  2. Add more sensible "selection centre"

    @LumpBloom7
    LumpBloom7 committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    8066df1 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2020

  1. Merge branch 'master' into Editor

    @LumpBloom7
    LumpBloom7 committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    cf9f82b View commit details
    Browse the repository at this point in the history

  2. Fix selection outlines

    @LumpBloom7
    LumpBloom7 committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    994c815 View commit details
    Browse the repository at this point in the history