Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SemaphoreTracker::track_semaphores_last_setter_ #70

Open
jeremyg-lunarg opened this issue Jun 27, 2024 · 0 comments
Open

Fix SemaphoreTracker::track_semaphores_last_setter_ #70

jeremyg-lunarg opened this issue Jun 27, 2024 · 0 comments

Comments

@jeremyg-lunarg
Copy link
Collaborator

This thing is supposed to track which queue or host operation last modified a semaphore. It requires allocating several buffer markers for each semaphore to track the which (queue, sequence number) or (host thread id) last touched it and the value that was set. Then, commands to update the markers must be added when a queue submission uses the semaphore. I broke all of this when I redid the queue submission code and got rid of the global submission ids. Probably it would be good to have a per semaphore history which assigns an id to each operation on the semaphore and stores all of the state. Then, the id can be written into a single marker then there wouldn't be a need to update 2-3 markers for every operation.

jeremyg-lunarg added a commit that referenced this issue Jun 27, 2024
It doesn't work correctly right now.

See #70
jeremyg-lunarg added a commit that referenced this issue Jun 27, 2024
It doesn't work correctly right now.

See #70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant