Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor develop #34

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Refactor develop #34

merged 3 commits into from
Nov 29, 2021

Conversation

LunatiqueCoder
Copy link
Owner

  • Removes baseUrl (default setting)
  • Refactor develop branch
  • More explanatory comments for React Native Vector Icons web integration

@LunatiqueCoder LunatiqueCoder self-assigned this Nov 29, 2021
@LunatiqueCoder LunatiqueCoder added the enhancement New feature or request label Nov 29, 2021
mikehardy
mikehardy approved these changes Nov 29, 2021
View reviewed changes
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool these all look like nice incremental improvements for anyone using this and trying to figure it out. I understand the RNVI-for-web stuff more now with the comments, personally!

@LunatiqueCoder LunatiqueCoder merged commit ce7514d into develop Nov 29, 2021
@LunatiqueCoder LunatiqueCoder deleted the refactor-develop branch November 29, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

Assignees

@LunatiqueCoder LunatiqueCoder

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LunatiqueCoder @mikehardy