Release 1.2.0 #35
Merged
Release 1.2.0 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this template is used to init a project, then the app directory itself is moved, the components inside app lose their ability to resolve and lint:types no longer works If I use directory-relative paths, everything appears fine
- requires gradle 7 versions to work with API31 build tools - requires exported attributes on activities to target api31 should be noted in release docs that JDK11 is required to build reliably
fix(android): android 12 compatibility
fix(paths): use directory-relative paths
the upstream code we can reuse uses these settings, to maintain character by character compatibility as much as possible, while allowing for a clean lint run here, reuse their lint settings this will decrease template maintenance burden here by allowing easy ingesetion of upstream changes from react-native-template-typescript
this allows the upstream react-native 'NewAppScreen' to work on web
allows deletion of majority of template contents, allows use of upstream react-native-typescript-template App.tsx almost without change, just wraps it in a toy navigator with toy vector icons demo
Why? Without this, you can't use `JSX.Element` etc as symbols because typescript-eslint does not understand they are present. `tsc` has no problem with the files. This is specifically recommended as a setting by the linter docs: https://github.com/typescript-eslint/typescript-eslint/blob/eaaa2047ca54f098dcdd32aaf5d8949495c6be26/docs/linting/TROUBLESHOOTING.md?plain=1#L111
they deprecated the old one: jsxBracketSameLine -> bracketSameLine https://prettier.io/blog/2021/09/09/2.4.0.html > This release renames the jsxBracketSameLine option to bracketSameLine, which supports HTML, Vue, and Angular in addition to JSX. The old name has been deprecated.
verified working, allows removal of ts-ignore/eslint-ignore, which gets rid of a warning about an unreported eslint-ignore
using spacing in eslint conflicts with spacing rules in prettier, and they *specifically* disagree on switch/case spacing in their default setups. Let Prettier control spacing, lint:all passes with fewer directives and pretty switch/case spacing.
Hopefully integrates via PR upstream in `@react-native-community`, this appears to be the standard configuration for no-shadow in typescript projects, see: react-native-community/react-native-template-typescript#238
…tegration for web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.