feat(web): add web-compatible linking and titling in react-navigation #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunatiqueCoder
approved these changes
Dec 4, 2021
|
Hmm I always wanted to try it out, can’t wait to get home and see it in action 😂 |
|
If I had done a CI action already you'd just go clicky click and see it haha. next week maybe |
I just started receiving this with the default settings on this template I'm a little surprised since this template is pretty lean for react-native, but this is common for me on other projects. Looks like it's time here
|
I tested this on native as an afterthought - obviously it's web-focused - and I had to bump gradle ram to run it, so I added that as a follow-on commit |
mikehardy
commented
Dec 4, 2021
LunatiqueCoder
approved these changes
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am new to the web stuff and forgot that managing the title URL in the browser bar is really important.
Not only does it pay to have the web title bar look nice (for bookmarking) but URL management is important for aesthetics, again for bookmarking (deep link recognition and page routing...) but most importantly: so the back button doesn't destroy your app's navigation state
So this adds a semi-fancy page title function as an example, and adds a third tab + config that shows how the whole thing works using the web-compatible version of react-navigation linking
As a PR it's kind of "meh" at the same time that I immediately noticed I needed it 2 layers up in my work projects, curious what you think here? If it looks good I'll expand it for the auth template