Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pages): auto-deploy to github-pages on merge to master #39

Merged

Conversation

mikehardy
Copy link
Collaborator

Fixes #37

First publish will fail as the gh-pages branch doesn't exist and Pages (in repo settings) isn't configured to use it

This should create the gh-pages branch first time it runs
Then configure Pages in repo settings to use the gh-pages branch
Then manually run the workflow again in the Actions tab on the repo (it responds to "workflow_dispatch" event, so you can run it manually)

It works!
https://github.com/invertase/react-native-firebase-authentication-example/runs/4423730053?check_suite_focus=true
https://invertase.github.io/react-native-firebase-authentication-example/

@LunatiqueCoder LunatiqueCoder added the enhancement New feature or request label Dec 5, 2021
@LunatiqueCoder LunatiqueCoder merged commit ffa1b86 into LunatiqueCoder:master Dec 5, 2021
@LunatiqueCoder
Copy link
Owner

Haha, that's so great actually 🤣

https://plaut-ro.github.io/luna/

Thanks for the help, this is a nice improvement!

@mikehardy
Copy link
Collaborator Author

yeah, it really shows off the web title and URL management. You can tell the area of my app I'm working on now 😆 ... deep link handling ugh, requires the URL management as foundation

@mikehardy mikehardy deleted the @mikehardy/github-pages branch December 5, 2021 20:34
@LunatiqueCoder
Copy link
Owner

Damn lucky you, I'm so curious how's it going for you with your app... I never worked on a real mobile+web React Native project, I created this template with the hope that I may need it one day. 😂

@mikehardy
Copy link
Collaborator Author

It's basically a nightmare, as I am behind on the deadline for a group of 3 apps really, and you're watching me learn as I go (in the form of PRs to this template and the auth example)

But at the same time, it's amazing because hey, what a mountain of stuff to learn, and I like learning.

You'll be able to see the web version of my biggest project soon, but the mobile versions for it already exist (just on older web tech - ReactXP before I converted it to react-native-web as you've watched me do here...) - https://komp.ai - not the most fun UI/UX but this webapp refresh should clean that all out. And it really does calculate a reasonable credit score based off device data, while being privacy conscious ;-)

@LunatiqueCoder
Copy link
Owner

But at the same time, it's amazing because hey, what a mountain of stuff to learn, and I like learning.

I know, right? I am also very curious so if you need a helping hand, don't hesitate to reach out for me. I'm sure I can take a couple of easy tasks off your head while you do the hard work. And it would also be a pleasure for me to stick my nose in such a project, lots of things for me to learn. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI should publish web app to github pages
2 participants