style(lint): remove eslint quotes rules so prettier wins #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
changed the title
prettier allows double-quotes on strings if you have a single-quote *in* the string that you would need to escape. It's subtle, but prettier eslint was trying to overrule that, so there was a linting battle this lets prettier win
mikehardy
force-pushed
the
@mikehardy/quotes-lint
branch
from
034f6d6 to
5d6be67
Compare
LunatiqueCoder
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prettier allows double-quotes on strings if you have a single-quote in
the string that you would need to escape. It's subtle, but prettier
eslint was trying to overrule that, so there was a linting battle
this lets prettier win
may not be generally applicable (it only happened to me when doing translations on authentication errors - lots of strings) but it simplifies the config so it seems reasonable to have it in the base layer of the templates