Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): yarn package:update, pin react-scripts@^4 #48

Merged

Conversation

mikehardy
Copy link
Collaborator

react-scripts@5 just came out and on a whim I tried it, it was not pretty 😅 - pinning react-scripts to v4 for now

The errors were all webpack - 4 total, 3 of them were duplicates in three different files: a babel interop helper file being required out of src with a relative path, not sure what that's about

And the fourth error was prettier having conflicted plugin loads from the community eslint config and our file

With this set of updates everything seems to run on all three platforms

@LunatiqueCoder
Copy link
Owner

Nice, I'll have a closer look probably today, but I have to admit - I'm very very crowded these days at work. :( I think only for Christmas I'll be able to revamp Luna a bit.

@mikehardy
Copy link
Collaborator Author

There is no pressure ever, I just lodge PRs when I'm "in the area" and if they sit, they sit :-). I'm still sitting on your web auth ones for instance 😅 - same reason, really busy in specific areas and those are not the areas at the moment. Cheers !

@LunatiqueCoder LunatiqueCoder self-requested a review December 20, 2021 06:42
@LunatiqueCoder LunatiqueCoder merged commit bba4753 into LunatiqueCoder:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants