fix: vector-icons android double-include, ios navigation stack crash, dependencies #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we include the react-native-vector-icons gradle script in our build.gradle, that script already takes care of merging in the font files as needed Including them in a fixed location in android assets is actually a double-inclusion. This was hidden before because the vector-icons gradle script moved them to the same spot, but with v9.1.0 of that package it exposed the issue with a build error. Delete them here, android still has icons, Fixes LunatiqueCoder#49
Strange that this is necessary, but it avoids a javascript crash on iOS only, in combination with react-navigation See invertase/react-native-firebase-authentication-example#9 (comment)
includes result of `./gradlew wrapper`
upstream fixed the issue that made this unreliable, so now it is once again the most reliable way to install pods
each of these are settings that will improve ios build performance - turning off warnings is useful because the build is so noisy it affects performance, and it is not actionable since it's not our code - turning on relative path usage for compiler binaries allows ccache use
LunatiqueCoder
approved these changes
Mar 5, 2022
|
Niiice, thank you. I believe this solves #49 ? |
|
Yep! And with my Fixes notation in the commit message it auto-closes, I'm all github-optimized ;-) |
|
My bad, it's almost 2AM here and my head is on another planet right now. But I will definitely sleep better with these changes 🚀 appreciate it 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit here is it's own thing really, but easier to do one PR with multiple clean commits that may be reviewed one at a time easily, then rebase-merge, versus 7 different PRs I think
Each commit has a descriptive message and should be clean, anyway :-)