-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tvOS Support #17
Conversation
…use button on showControls
@esegebart Let's write here any issues that we can find today with the tvOS support. I am testing it on my project which is a bare React Native project, (without tvOS) all and it seems to be working very good so far. Please be sure you have the latest release candidate installed by using If everything goes well in our testing, we'll release it so everybody can enjoy the tvOS support 🎉 |
Amazing! I will be trying it out today on bare project. |
@criszz77 Yes, I had made the project as you said in the previous discussion with typescript and I got an error. Here are some screenshots, react-native info, and packages. React-native info
ScreenshotsPackages
This was tested on Android TV emulator. My project with the tvOS package is still working with the current version of react-native-media-console. |
@esegebart It's a bare React Native project, so there's no support for tvOS, only for mobile. 🥺 Should work if you try on a mobile simulator? |
@esegebart Sorry for the confusion, but I also changed the issue into a discussion here: #20 |
@criszz77 Oh wow, I am dense today. Of course it wouldn't work on tv simulator. :D Forgive me LOL. |
Yes. Works perfectly on mobile! WOO it's been a long couple days, sorry! LOL |
This PR adds a minimal support for tvOS solving #15
Run
yarn add react-native-media-console@next
to check it out.@esegebart Please try this version out as I made some small refactor and my Android TV simulator does not work anymore for some reason :( I will test it too on mobile only on my project.