fix(form): animate sorting of collapsible sections #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-2562/ |
Kiarokh
commented
Oct 27, 2023
| } | ||
|
|
||
| // Perform the action | ||
| event.detail.run(event); |
There was a problem hiding this comment.
We have to wait for the transitions to happen, and then update the index number and simultaneously and instantly remove the transition classes. This timing however doesn't seem to work always. Maybe the implementation should be totally different. I don't know
Kiarokh
commented
Oct 27, 2023
Comment on lines
+293
to
+298
| &.move-up-transition { | ||
| transform: translateY(-100%); | ||
| } | ||
| &.move-down-transition { | ||
| transform: translateY(100%); | ||
| } |
There was a problem hiding this comment.
this only works when all collapsible sections have the same size. So for example if one is closed and one is open, this doesn't work and make a silly visual effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: