fix(dynamic-form): change example from textarea to code-editor #3199
Conversation
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3199/ |
| fold={true} | ||
| onChange={this.handleTextChange} | ||
| value={this.text} | ||
| ></limel-code-editor>, |
There was a problem hiding this comment.
| ></limel-code-editor>, | |
| />, |
Just a style/taste. But the code looks cleaner and we normally do that when elements don't wrap anything else.
| @@ -45,7 +45,14 @@ export class DynamicFormExample { | |||
|
|
|||
| public render() { | |||
| return [ | |||
| <textarea onChange={this.handleTextChange}>{this.text}</textarea>, | |||
There was a problem hiding this comment.
in the previous version, one could typ inside the textarea and see the results live in the form below. We should make sure that the same thing happens when using the code-editor
There was a problem hiding this comment.
the commit type is docs in this case, not fix. Since we are only changing something in the documentations, and not fixing any bugs or problems in the component's code
There was a problem hiding this comment.
let me know if you want help changing the title 😊
| @@ -1,4 +1,3 @@ | |||
| textarea { | |||
| limel-code-editor { | |||
There was a problem hiding this comment.
| limel-code-editor { | |
| limel-code-editor { | |
paulinewahle
force-pushed
the
dynamic-schema-code-editor
branch
2 times, most recently
from
ee36236 to
33be529
Compare
paulinewahle
force-pushed
the
dynamic-schema-code-editor
branch
from
33be529 to
1b6d8f8
Compare
fix: #1859
Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: