Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too dark edges in BIDIR mode #237

Closed
ivovanderlans opened this issue Sep 23, 2019 · 9 comments
Closed

Too dark edges in BIDIR mode #237

ivovanderlans opened this issue Sep 23, 2019 · 9 comments
Assignees

Comments

@ivovanderlans
Copy link

ivovanderlans commented Sep 23, 2019

A simple scene with a point light that reflects onto
a mirror that reflects onto a glossy backdrop plane
and a matte cube that are observed by a square camera.
There is no lighting from the world/environment.

The render engine is set up for BI-directional path
tracing at default settings. The image output is set
for 64-by-64 pixels to speed up the rendering.

BUG: the top and right-most edge of the output image
are darker than the rest of the image with no apparent
reason. When switching to the forward path tracer, the
problem is gone but convergence is way too slow. Using
the forward path tracer with added light tracing again
introduces the problem and emphasizes it even more.

I found the bug using the latest BlendLuxCore addin for Blender3D 2.80 but suspect that the issue is with LuxCore itself. The attached blend file shows the issue:

LuxCore bug.zip

@Dade916 Dade916 self-assigned this Sep 23, 2019
@Dade916
Copy link
Member

Dade916 commented Sep 23, 2019

I have recently fixed a similar bug: https://forums.luxcorerender.org/viewtopic.php?f=4&t=1409&p=16428#p16428

What LuxCore version are you using ?

@ivovanderlans
Copy link
Author

ivovanderlans commented Sep 23, 2019

I am using the latest BlendLuxCore (beyond v2.2RC1) from here: https://github.com/LuxCoreRender/BlendLuxCore/releases/tag/latest (downloaded last week). Be aware that the bug is not about the edges of objects/geometry but of the output image itself.

@ivovanderlans
Copy link
Author

Too dark edges in BIDIR mode
See the upper row and rightmost column in the attached rendered image .

@Dade916
Copy link
Member

Dade916 commented Sep 23, 2019

Ok, you mean the first top raw of pixels and the rightmost are black, right ?

@ivovanderlans
Copy link
Author

Well, darker really - not exactly black. I have another much more complex blend file (containing proprietary research data which I cannot share) where that row and column is less dark but still too dark (by about 10%).

@ivovanderlans
Copy link
Author

It looks to me like LuxCore has the pixel grid shifted down and left by a fraction of a pixel width, but only for the light rays.

@Dade916
Copy link
Member

Dade916 commented Sep 23, 2019

If you set the pixel filter to "NONE" (otherwise, each pixel affects the neighbors) the black pixels are clearly visible:

RGB_IMAGEPIPELINE_0

The image is shifted down and left by one pixel, checking why...

P.S. if you use "METROPOLIS" sampler instead of "SOBOL", the rendering will be a lot faster.

Dade916 added a commit that referenced this issue Sep 23, 2019
@Dade916
Copy link
Member

Dade916 commented Sep 23, 2019

Ok, I should have fixed the problem. The fix will be included in the next automatic build: https://forums.luxcorerender.org/viewtopic.php?f=9&t=736

It should be ready in 2-3 hours.

@ivovanderlans
Copy link
Author

Yup; fixed. Thank you for the fast response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants