Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KernelCacheFill() does not allow to specify min/max epsilon #374

Closed
Theverat opened this issue May 19, 2020 · 4 comments
Closed

KernelCacheFill() does not allow to specify min/max epsilon #374

Theverat opened this issue May 19, 2020 · 4 comments
Assignees

Comments

@Theverat
Copy link
Member

Would it make sense to add that here?

const Property renderEngines = config.Get(Property("kernelcachefill.renderengine.types")("PATHOCL", "TILEPATHOCL", "RTPATHOCL"));

@Dade916 Dade916 self-assigned this May 20, 2020
@Dade916
Copy link
Member

Dade916 commented May 20, 2020

It is already there (?): you can set min/max epsilon with the properties you are passing to KernelCacheFill().

@Theverat
Copy link
Member Author

From what I can see in the linked code, no: A new Properties instance "cfgProps" is created and only the renderengine from kernelcachefill.renderengine.types is set on them. The rest of the passed-in config properties is ignored, or am I overlooking something?

Dade916 added a commit that referenced this issue May 20, 2020
…epsilon.min and scene.epsilon.max properties (issue #374)
@Dade916
Copy link
Member

Dade916 commented May 20, 2020

Ok, luxcore::KernelCacheFill() now supports opencl.devices.select, scene.epsilon.min and scene.epsilon.max properties.

@Theverat
Copy link
Member Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants