Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhotonGI Cache problem with light from different lightgroups inside other lightgroups #414

Closed
juangea opened this issue Jul 24, 2020 · 5 comments

Comments

@juangea
Copy link

juangea commented Jul 24, 2020

I'm not sure how to explain it, so I decided to prepare a Blender file and publish some pictures.

In the blend file you will see three light groups:

  • Interior lights
  • exterior lights
  • environment

If you press render you will see in this case that the lights from other lightgroups are present everywhere, in other more complex scenes you can even see like a weird light leak.

I forced the energy of the lights to show more the problem, if you reduce the power of each light the problem is less visible but it's still there in the form of something like fireflies or weird noise.

These are the results of the light groups:

Exterior lights light groups, you can see the interior lights effect where it should not be:
image

Interior lights light group, you can see the exterior lights effect there, it should not be there:
image

And here is the environment light light group, the problem is obvious :) :
image

Attached is the .blend from this.

I hope this helps.

lux_24_gicache_test.blend.zip

Thanks!

@Dade916 Dade916 self-assigned this Jul 25, 2020
@Dade916
Copy link
Member

Dade916 commented Jul 25, 2020

I'm looking into the problem. I started disabling both DLS and PhotonGI cache. A rendering with area light groups disabled already looks strange:

normal

There are far less fireflies but they are still there (i.e. the problem may be not strictly related to the caches, they may only amplify a bug somewhere else).
I'm aware that light groups can have precision problems (i.e. the value resolution is not infinite so the initial ratio between different light groups intensities does matter) however this looks like something else.

@juangea
Copy link
Author

juangea commented Jul 25, 2020

Great, at least this bug came to the surface 👍

@Dade916
Copy link
Member

Dade916 commented Jul 26, 2020

This problem was driving me crazy but, at the end, it is just the result of an extreme (and wrong) variance clamping setting. The clamping is set to 5 but the scenes has values of 100 or higher, this leads to all sort of problems.

If you rise the clamp value to 100+ (or disable), everything will work as expected.

This is somewhat the result of variance clamping being applied to the complete image (i.e. the sum of all light groups) without any regard for light groups. I can think to apply variance clamping to each light group instead of the complete image but this would be a new feature (for v2.5), not a bug fix for v2.4.

@Dade916
Copy link
Member

Dade916 commented Jul 26, 2020

I have added the support for variance clamping applied separately to each radiance group to v2.5 and it handles well this scene even with the original clamping setting of 5.

@Dade916 Dade916 closed this as completed Jul 28, 2020
@juangea
Copy link
Author

juangea commented Jul 28, 2020

Great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants