Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haltSPP_ScreenNormalized check not working correctly #497

Closed
BeheadedKamikaze opened this issue Jan 26, 2021 · 2 comments
Closed

haltSPP_ScreenNormalized check not working correctly #497

BeheadedKamikaze opened this issue Jan 26, 2021 · 2 comments
Assignees
Labels

Comments

@BeheadedKamikaze
Copy link

BeheadedKamikaze commented Jan 26, 2021

It appears that in the comparison in the first halt case (line 1356), the variables for samples completed (spp_ScreenNormalized) and the user setting (haltSPP_ScreenNormalized ) have been swapped, resulting in the render terminating as soon as the eye samples have completed (assuming the eye samples complete before the light samples do).

(haltSPP_ScreenNormalized > 0) && (haltSPP_ScreenNormalized > spp_ScreenNormalized)

I think it should appear like the check in the third case (line 1366):

(haltSPP_ScreenNormalized > 0) && (spp_ScreenNormalized > haltSPP_ScreenNormalized)

Potential bug: should the user's CPU be much faster than their GPU, spp_ScreenNormalized exceeds the user setting before spp_PixelNormalized does, then the render might never complete.

@Dade916 Dade916 self-assigned this Jan 29, 2021
Dade916 added a commit that referenced this issue Jan 29, 2021
@Dade916 Dade916 added the bug label Jan 29, 2021
@Dade916
Copy link
Member

Dade916 commented Jan 29, 2021

Thanks, I should have fixed the problem.

@BeheadedKamikaze
Copy link
Author

Thank-you, Dade!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants