Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star us in nav-bar #192

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Star us in nav-bar #192

wants to merge 4 commits into from

Conversation

lazarusA
Copy link
Collaborator

@lazarusA lazarusA commented Dec 3, 2024

This adds a new vue component showing the stars on Github, this might potentially motivate users to click on it and give one more star easily 😄 .

@avik-pal
Copy link
Member

avik-pal commented Dec 3, 2024

Might look better if we can combine it with the github social icon

@lazarusA
Copy link
Collaborator Author

lazarusA commented Dec 3, 2024

yes, it would be nice. Haven't looked into it. But, I might need to remove the social icon in the config file and put it here instead...

@lazarusA
Copy link
Collaborator Author

lazarusA commented Dec 3, 2024

Ok. This will give us the GitHub icon plus stars.
Some caveats:

  • 1 it will be always inserted at the end of the nav-bar-content
  • 2 as it is, is necessary to write the corresponding repo (this should be automated)
  • 3 and this social icon should not be included in the social links within the config.mts file.

if we decide to move forward at least (2) should be resolved. Other than that, this looks good. Copy/pasting the corresponding files and doing manual typing in other sites should work and be fine 😄 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants