Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow no grad option for reactant #1190

Merged
merged 1 commit into from
Jan 8, 2025
Merged

feat: allow no grad option for reactant #1190

merged 1 commit into from
Jan 8, 2025

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Jan 8, 2025

fixes #1181

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

Benchmark Results (ASV)

main e56b36e... main/e56b36e2471128...
basics/overhead 0.124 ± 0.0014 μs 0.123 ± 0.0015 μs 1.01
time_to_load 0.924 ± 0.018 s 0.914 ± 0.013 s 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@avik-pal avik-pal merged commit c81629b into main Jan 8, 2025
35 of 44 checks passed
@avik-pal avik-pal deleted the ap/no_grad branch January 8, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No Grad option for TrainState single_train_step(!)
1 participant
@avik-pal