[Enzyme] Mark certain operations as Enzyme inactive #69
Conversation
avik-pal
force-pushed
the
ap/mark_inactive
branch
3 times, most recently
from
be96fce to
12f75f7
Compare
avik-pal
force-pushed
the
ap/mark_inactive
branch
3 times, most recently
from
e044ebd to
5e4ef71
Compare
avik-pal
force-pushed
the
ap/mark_inactive
branch
from
5e4ef71 to
2feccc9
Compare
| @@ -130,6 +130,7 @@ end | |||
| @inline _dropout_fptype(x) = float(real(eltype(x))) | |||
|
|
|||
| CRC.@non_differentiable _dropout_fptype(::Any...) | |||
| EnzymeRules.inactive(::typeof(_dropout_fptype), ::Any...) = nothing | |||
|
|
|||
There was a problem hiding this comment.
can you see if it still works if you change to inactive_noinl for all of these?
It will be performant if so
There was a problem hiding this comment.
I think some of these are not needed at all. Is there a cost of defining these functions?
There was a problem hiding this comment.
inactive_noinl is strictly beneficial. It adds inactive metadata to the call/body which can improve performance or do nothing in the worst case if Enzyme can already prove it inactive on own.
inactive itself will stop inlining so there's a potential performance penalty. It will, however, guarantee that the activity information is propagated (whereas the top is presently a best effort procedure).
|
It's worthwhile still keeping the other ones as noinl FYI |
This reverts commit 1a64b73.
No description provided.