Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple concurrent calls to the same rule don't trigger cooldown #59

Open
Luzifer opened this issue Mar 28, 2024 · 0 comments
Open

Multiple concurrent calls to the same rule don't trigger cooldown #59

Luzifer opened this issue Mar 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Luzifer
Copy link
Owner

Luzifer commented Mar 28, 2024

As a streamer I want my cooldowns to be honored even though multiple user trigger the same command in the same moment.

At the moment i.e. triggering a !dc+ twice in the same "second" counts two deaths even though there is a 30s cooldown on the !dc+ rule.

The cause for this is the rule only to be sent to cooldown after the execution which takes a moment. To solve this the rule needs to be locked. This lock though should take into account which cooldowns are set on the rule not to lock the rule for all channels if there is a channel-based cooldown on it.

@Luzifer Luzifer added the bug Something isn't working label Mar 28, 2024
Luzifer added a commit that referenced this issue May 1, 2024
refs #59

ensures counter actions are not triggered concurrently by two persons

Signed-off-by: Knut Ahlers <knut@ahlers.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant